Introduce a ChatId domain type

weiwen commented

2026-07-05 13:10:22 +08:00

Owner

What to build

The chat-id string that keys every session (tg-{telegram_id}, api-{client_id}) is currently hand-built with format! in five places, its validation rule lives alone in the HTTP interface, and the session-id minting ({chat_id}_{timestamp}) lives in the session manager. CONTEXT.md documents a format the code does not actually produce. Introduce a single ChatId domain type that owns all three concerns — namespacing, validation, and session-id minting — so the format has exactly one home and cannot drift again.

This is a pure refactor: keep the existing wire format (tg-/api- hyphen namespaces, Unix-epoch session timestamp). Reconcile the documented drift by updating CONTEXT.md to match the code (hyphen + epoch), NOT by changing the code — so no session-map keys or on-disk session filenames change.

Decision from grilling — enum representation:

enum ChatId {
    Telegram(i64),   // Display -> "tg-{id}"
    Api(String),     // Display -> "api-{validated id}"
}
impl ChatId {
    fn telegram(id: i64) -> ChatId;                    // infallible
    fn api(raw: &str) -> Result<ChatId, ChatIdError>;  // absorbs the current HTTP validation
    fn session_id(&self, ts: i64) -> String;           // "{self}_{ts}"; timestamp is a param (pure/testable)
}
impl Display for ChatId;

ChatIdError maps into the HTTP interface's existing InvalidChatId variant via #[from], preserving the current 400 response and messages. The Telegram whitelist check keeps comparing the raw i64; ChatId is only for the session key and session id.

Acceptance criteria

ChatId enum with telegram, fallible api, session_id(ts), and Display, in its own module.
All five format!("tg-…") / format!("api-…") sites and the session-id minting go through ChatId.
The HTTP chat-id validation rule (length 1–64; alphanumeric, -, _) lives on ChatId::api; the HTTP handler calls it and maps the error to the existing invalid_chat_id 400 response.
Wire format unchanged (tg-{id}, api-{id}, {chat_id}_{epoch}), verified by unit tests on Display and session_id.
session_id takes the timestamp as a parameter and is unit-tested deterministically.
CONTEXT.md Chat ID / Session ID entries updated to describe the actual format (hyphen namespaces, epoch timestamp).
just check green.

Blocked by

None - can start immediately.

## What to build The chat-id string that keys every session (`tg-{telegram_id}`, `api-{client_id}`) is currently hand-built with `format!` in five places, its validation rule lives alone in the HTTP interface, and the session-id minting (`{chat_id}_{timestamp}`) lives in the session manager. `CONTEXT.md` documents a format the code does not actually produce. Introduce a single `ChatId` domain type that owns all three concerns — namespacing, validation, and session-id minting — so the format has exactly one home and cannot drift again. This is a **pure refactor**: keep the existing wire format (`tg-`/`api-` hyphen namespaces, Unix-epoch session timestamp). Reconcile the documented drift by updating `CONTEXT.md` to match the code (hyphen + epoch), NOT by changing the code — so no session-map keys or on-disk session filenames change. Decision from grilling — enum representation: ```rust enum ChatId { Telegram(i64), // Display -> "tg-{id}" Api(String), // Display -> "api-{validated id}" } impl ChatId { fn telegram(id: i64) -> ChatId; // infallible fn api(raw: &str) -> Result<ChatId, ChatIdError>; // absorbs the current HTTP validation fn session_id(&self, ts: i64) -> String; // "{self}_{ts}"; timestamp is a param (pure/testable) } impl Display for ChatId; ``` `ChatIdError` maps into the HTTP interface's existing `InvalidChatId` variant via `#[from]`, preserving the current 400 response and messages. The Telegram whitelist check keeps comparing the raw `i64`; `ChatId` is only for the session key and session id. ## Acceptance criteria - [ ] `ChatId` enum with `telegram`, fallible `api`, `session_id(ts)`, and `Display`, in its own module. - [ ] All five `format!("tg-…")` / `format!("api-…")` sites and the session-id minting go through `ChatId`. - [ ] The HTTP chat-id validation rule (length 1–64; alphanumeric, `-`, `_`) lives on `ChatId::api`; the HTTP handler calls it and maps the error to the existing `invalid_chat_id` 400 response. - [ ] Wire format unchanged (`tg-{id}`, `api-{id}`, `{chat_id}_{epoch}`), verified by unit tests on `Display` and `session_id`. - [ ] `session_id` takes the timestamp as a parameter and is unit-tested deterministically. - [ ] `CONTEXT.md` Chat ID / Session ID entries updated to describe the actual format (hyphen namespaces, epoch timestamp). - [ ] `just check` green. ## Blocked by None - can start immediately.

weiwen added the

ready-for-agent

label

2026-07-05 13:10:22 +08:00

weiwen referenced this issue

2026-07-05 13:10:46 +08:00

Per-session locking: stop holding the map lock across a pi turn #33

weiwen commented

2026-07-05 13:40:32 +08:00

Author

Owner

Implemented ChatId domain type on branch sandcastle/issue-31 (commit 63130cf).

What was done:

New src/chat_id.rs: ChatId enum (Telegram(i64) / Api(String)) with Display (tg-{id} / api-{id}), infallible telegram(), fallible api() (absorbs validation logic), session_id(ts) for deterministic session ID minting. ChatIdError (InvalidLength/InvalidChars) maps to ApiError::InvalidChatId via #[from].
All five format!("tg-…") / format!("api-…") sites replaced with EvieChatId::telegram(id) / ChatId::api(raw)?.
SessionManager::send_message, clear_session, get_status now accept &ChatId; session IDs minted via chat_id.session_id(ts).
CONTEXT.md Chat ID / Session ID glossary updated to match actual wire format (hyphen separator, Unix-epoch timestamp).

Notes: No Rust toolchain available in sandbox — CI must validate compilation and tests.

Implemented `ChatId` domain type on branch `sandcastle/issue-31` (commit 63130cf). **What was done:** - New `src/chat_id.rs`: `ChatId` enum (`Telegram(i64)` / `Api(String)`) with `Display` (`tg-{id}` / `api-{id}`), infallible `telegram()`, fallible `api()` (absorbs validation logic), `session_id(ts)` for deterministic session ID minting. `ChatIdError` (InvalidLength/InvalidChars) maps to `ApiError::InvalidChatId` via `#[from]`. - All five `format!("tg-…")` / `format!("api-…")` sites replaced with `EvieChatId::telegram(id)` / `ChatId::api(raw)?`. - `SessionManager::send_message`, `clear_session`, `get_status` now accept `&ChatId`; session IDs minted via `chat_id.session_id(ts)`. - `CONTEXT.md` Chat ID / Session ID glossary updated to match actual wire format (hyphen separator, Unix-epoch timestamp). **Notes:** No Rust toolchain available in sandbox — CI must validate compilation and tests.

weiwen commented

2026-07-05 19:03:14 +08:00

Author

Owner

Implementation complete on branch sandcastle/issue-31. All acceptance criteria met: ChatId enum with telegram/api/session_id/Display in chat_id.rs, all format! sites consolidated, HTTP validation absorbed into ChatId::api(), CONTEXT.md updated. No Rust toolchain in sandbox — CI must confirm just check green.

weiwen referenced this issue from a commit

2026-07-06 01:18:35 +08:00

feat: introduce ChatId domain type — closes #31

weiwen referenced this issue from a commit

2026-07-06 01:21:20 +08:00

feat: introduce ChatId domain type — closes #31

weiwen closed this issue

2026-07-06 01:21:20 +08:00