sandcastle: fix implement-prompt feedback loop (npm -> just check) #13

New issue

Closed

opened 2026-07-05 03:21:38 +08:00 by weiwen · 0 comments

weiwen commented

2026-07-05 03:21:38 +08:00

Owner

Blocked by: #9, #10, #11

Why

.sandcastle/implement-prompt.md tells the implementer, before committing, to run:

Before committing, run `npm run typecheck` and `npm run test` to ensure the tests pass.

But evie is a Rust project with no npm scripts (package.json has only deps, no scripts). So the implementer's pre-commit feedback loop is a no-op — it never actually type-checks or tests the Rust code.

What

Replace the npm run typecheck && npm run test instruction with nix develop .#ci -c just check (fmt + clippy + test).
Sanity-check the rest of the prompt for other TypeScript-template leftovers (the RGR section is fine; it's the feedback-loop command that's wrong).

Acceptance criteria

implement-prompt.md instructs running nix develop .#ci -c just check before committing.
No remaining npm run ... build/test references in the prompt.

Note

Depends on #10 (just check recipe), #9 (ci devShell), and #11 (image can run it). Purely a prompt edit; safe to land once the toolchain is real.

Blocked by: #9, #10, #11 ## Why `.sandcastle/implement-prompt.md` tells the implementer, before committing, to run: > Before committing, run \`npm run typecheck\` and \`npm run test\` to ensure the tests pass. But evie is a Rust project with no npm scripts (`package.json` has only deps, no `scripts`). So the implementer's pre-commit feedback loop is a **no-op** — it never actually type-checks or tests the Rust code. ## What - Replace the `npm run typecheck && npm run test` instruction with `nix develop .#ci -c just check` (fmt + clippy + test). - Sanity-check the rest of the prompt for other TypeScript-template leftovers (the RGR section is fine; it's the feedback-loop command that's wrong). ## Acceptance criteria - `implement-prompt.md` instructs running `nix develop .#ci -c just check` before committing. - No remaining `npm run ...` build/test references in the prompt. ## Note Depends on #10 (`just check` recipe), #9 (ci devShell), and #11 (image can run it). Purely a prompt edit; safe to land once the toolchain is real.

weiwen added the

ready-for-agent

label

2026-07-05 03:40:25 +08:00

weiwen referenced this issue from a commit

2026-07-05 03:54:13 +08:00

RALPH: add just check recipe (closes #10)

weiwen referenced this issue from a commit

2026-07-05 08:33:37 +08:00

RALPH: fix implement-prompt feedback loop (npm -> just check)

weiwen referenced this issue from a pull request that will close it,

2026-07-05 08:33:48 +08:00