sandcastle: fix implement-prompt feedback loop (npm -> just check) #26

Merged

weiwen merged 1 commit from sandcastle/issue-13 into main

2026-07-05 12:01:15 +08:00

weiwen commented

2026-07-05 08:33:48 +08:00

Owner

What changed and why

The sandcastle implement-prompt instructed agents to run npm run typecheck and npm run test before committing. This project uses just as its task runner, so those npm commands don't exist — agents running the feedback loop would fail.

This PR replaces those two npm commands with a single just check invocation, which is the correct command for this repo.

Key decisions

Single-line change in .sandcastle/implement-prompt.md
just check is already the established convention in this repo (see recent CI changes)
No other references to the npm commands were found in the sandcastle prompts

Reviewer checklist

Confirm just check runs typecheck + tests as expected on this repo
No other sandcastle prompt files need updating

Closes #13

## What changed and why The sandcastle implement-prompt instructed agents to run `npm run typecheck` and `npm run test` before committing. This project uses `just` as its task runner, so those npm commands don't exist — agents running the feedback loop would fail. This PR replaces those two npm commands with a single `just check` invocation, which is the correct command for this repo. ## Key decisions - Single-line change in `.sandcastle/implement-prompt.md` - `just check` is already the established convention in this repo (see recent CI changes) - No other references to the npm commands were found in the sandcastle prompts ## Reviewer checklist - Confirm `just check` runs typecheck + tests as expected on this repo - No other sandcastle prompt files need updating Closes #13

weiwen added the

ready-for-human

label

2026-07-05 08:33:48 +08:00

weiwen added 1 commit

2026-07-05 08:33:48 +08:00

RALPH: fix implement-prompt feedback loop (npm -> just check)

CI / check (pull_request) Failing after 2m5s

Details

fab1c29109

Closes #13

Task: Replace `npm run typecheck` and `npm run test` with `just check`
in the implement-prompt.md FEEDBACK LOOPS section. The project is a Rust
codebase that uses `just check` (cargo fmt --check + cargo clippy + cargo
test) as documented in CODING_STANDARDS.md; the npm commands were never
valid here.

Files changed:
- .sandcastle/implement-prompt.md: FEEDBACK LOOPS section updated

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

weiwen merged commit e6fbc7e10b into main

2026-07-05 12:01:15 +08:00

weiwen deleted branch sandcastle/issue-13

2026-07-05 12:01:15 +08:00