Typed Snapshot: move Telegram preview styling out of pi transport #36

Merged

weiwen merged 1 commit from sandcastle/issue-32 into main

2026-07-06 01:09:56 +08:00

weiwen commented

2026-07-05 13:40:05 +08:00

Owner

Summary

Introduces a typed Snapshot enum (Text(String) | Thinking(String)) in src/pi.rs to replace the raw String previously sent over the snapshot channel. This separates what the pi transport observed from how a given interface chooses to render it.

Key decisions:

The pi transport now emits raw content with no presentation logic — no emoji prefix, no character trim. Presentation is the caller's responsibility.
thinking_preview (emoji prefix + 3800-char tail trim) and its constant were moved verbatim from src/pi.rs to src/telegram/mod.rs, which is the only caller that needs Telegram-specific sizing.
The HTTP interface already discarded snapshots; its channel type annotation is updated to Snapshot for consistency (src/http.rs).
Tests in pi.rs were updated to assert on typed Snapshot variants; three focused unit tests for thinking_preview were added directly in src/telegram/mod.rs.

Reviewer should check:

The Snapshot enum variants and their doc comments in src/pi.rs.
That thinking_preview in src/telegram/mod.rs is functionally identical to what was removed from src/pi.rs.
The tokio::select! arms in deliver_response (telegram) correctly dispatch Snapshot::Text and Snapshot::Thinking.

Closes #32

## Summary Introduces a typed `Snapshot` enum (`Text(String)` | `Thinking(String)`) in `src/pi.rs` to replace the raw `String` previously sent over the snapshot channel. This separates *what* the pi transport observed from *how* a given interface chooses to render it. **Key decisions:** - The pi transport now emits raw content with no presentation logic — no emoji prefix, no character trim. Presentation is the caller's responsibility. - `thinking_preview` (emoji prefix + 3800-char tail trim) and its constant were moved verbatim from `src/pi.rs` to `src/telegram/mod.rs`, which is the only caller that needs Telegram-specific sizing. - The HTTP interface already discarded snapshots; its channel type annotation is updated to `Snapshot` for consistency (`src/http.rs`). - Tests in `pi.rs` were updated to assert on typed `Snapshot` variants; three focused unit tests for `thinking_preview` were added directly in `src/telegram/mod.rs`. **Reviewer should check:** - The `Snapshot` enum variants and their doc comments in `src/pi.rs`. - That `thinking_preview` in `src/telegram/mod.rs` is functionally identical to what was removed from `src/pi.rs`. - The `tokio::select!` arms in `deliver_response` (telegram) correctly dispatch `Snapshot::Text` and `Snapshot::Thinking`. Closes #32

weiwen added the

ready-for-human

label

2026-07-05 13:40:05 +08:00

weiwen added 1 commit

2026-07-05 13:40:05 +08:00

RALPH: Typed Snapshot: move Telegram preview styling out of pi transport

CI / check (pull_request) Successful in 2m5s

Details

dff9573e94

Closes #32

Defines `pub enum Snapshot { Text(String), Thinking(String) }` in the pi
module with `PartialEq` so dedup stays in pi. The streaming channel
becomes `UnboundedSender<Snapshot>` end-to-end. Pi emits `Text` when the
assistant message carries text, else `Thinking` with the raw thinking
string — no emoji, no trim. The 💭 prefix and tail-trim (now
`thinking_preview()` + `THINKING_PREVIEW_CHAR_LIMIT`) move into
`telegram/mod.rs`, which renders `Text` as-is and `Thinking` via
`preview()`. HTTP path passes a detached channel and ignores it, no
behaviour change there.

Key decisions:
- `last_snapshot: Option<Snapshot>` replaces `last_snapshot: String`; dedup
  uses `Some(&snapshot) != last_snapshot.as_ref()` to avoid cloning for the
  comparison.
- Pi stream-parsing tests updated to assert `Snapshot::Text`/`Snapshot::Thinking`
  variants; `test_thinking_preview_tail_bounded` replaced by
  `test_thinking_emits_raw_text_without_trim_or_emoji` (pi no longer trims).
- Three new tests for `thinking_preview()` added to telegram module.

Files changed:
- src/pi.rs: Snapshot enum, remove THINKING_PREVIEW_CHAR_LIMIT/thinking_preview,
  retype channel, update read_agent_response + all tests
- src/session.rs: retype snapshot_tx parameter
- src/http.rs: explicit ::<Snapshot> on detached channel
- src/telegram/mod.rs: import Snapshot, add thinking_preview, retype channel,
  render Text/Thinking variants, new tests

Blockers/notes:
- No Rust toolchain in sandbox; CI must validate compilation and tests.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>